Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: about footer.swig #1541

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KumaNNN
Copy link

@KumaNNN KumaNNN commented Aug 3, 2020

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build & CI related changes.
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

  1. http://www.beian.miit.gov.cn/ Sometimes the visit is slow
  2. mermaid tag. This tag wrong use of .highlight style as background
    2

What is the new behavior?

  1. http://www.beian.miit.gov.cn/ Sometimes the visit is slow, it is recommended to use a URL similar to http://gd.beian.miit.gov.cn/. See commit e5a1501

    www.beian.miit.gov.cn => gd.beian.miit.gov.cn
    
  2. Fix mermaid tag. See commit 91df761
    aa

  3. Fix foot content display,display the character Copyright and add custom links. See commit e5a1501
    Copyright

How to use?

In NexT _config.yml:

footer:
  ... ...
  # If not defined, `author` from Hexo `_config.yml` will be used.
  copyright:
  copyright_url: 
  ... ...
  # Beian ICP and gongan information for Chinese users. See: http://www.beian.miit.gov.cn, http://www.beian.gov.cn
  beian:
    enable: false
    icp:
    # ICP region. See: http://www.miit.gov.cn/n1146285/n1146352/n3054355/n3057709/n3057722/c6797266/content.html
    icp_region: gd
   ... ...

New options is copyright_url and icp_region.

@KumaNNN
Copy link
Author

KumaNNN commented Aug 3, 2020

@jiangtj

@KumaNNN KumaNNN marked this pull request as ready for review August 3, 2020 14:06
@KumaNNN
Copy link
Author

KumaNNN commented Aug 6, 2020

@jiangtj
Can you pass PR?

@sli1989
Copy link
Collaborator

sli1989 commented Sep 2, 2020

features and improvements would be tried in here https://github.com/next-theme/hexo-theme-next/pulls, thanks.


and remember one pr with one bug or feature.

GitHub
🎉 Elegant and powerful theme for Hexo. Contribute to next-theme/hexo-theme-next development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants